Skip to content

Conversation

@jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Dec 10, 2024

These data placeholders are meant to indicate values that are already clearly indicated in the plots themselves.
Showing the same values twice is bad data story-telling practice and confusing to the user.

Supersedes #122

@jdhoffa jdhoffa requested a review from AlexAxthelm December 10, 2024 10:05
@jdhoffa jdhoffa requested a review from MonikaFu as a code owner December 10, 2024 10:05
@github-actions
Copy link

github-actions bot commented Dec 10, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-10 10:29 UTC

@github-actions
Copy link

Docker build status

commit_time git_sha image
2024-12-10T10:05:25Z ae4d0e2 ghcr.io/rmi-pacta/pacta-dashboard-svelte:pr-152

@jdhoffa jdhoffa merged commit 0314109 into main Dec 10, 2024
11 checks passed
@jdhoffa jdhoffa deleted the remove_superfluous_data branch December 10, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants